Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ui test for crypto payment flow initiation and return #1933

Merged
merged 19 commits into from
Feb 11, 2022
Merged

Add ui test for crypto payment flow initiation and return #1933

merged 19 commits into from
Feb 11, 2022

Conversation

asnaith
Copy link
Member

@asnaith asnaith commented Feb 10, 2022

closes #1921

  • Walks through buying a plan with a crypto and closes out the modal before making payment. Ensures we can return to the payment flow via "Pay Now" buttons on Settings / Billing history

asnaith and others added 16 commits January 31, 2022 15:32
@asnaith
add new ui tests for annual and monthly billing options
99aa596
@Tbaut
Merge branch 'dev' into mnt/plan-toggle-ui-tests-1898
65d46a0
@Tbaut
Merge branch 'dev' into mnt/plan-toggle-ui-tests-1898
deb0634
@asnaith
Merge branch 'dev' into mnt/plan-toggle-ui-tests-1898
15fd378
@asnaith
Merge branch 'dev' into mnt/plan-toggle-ui-tests-1898
d4c8dfb
@Tbaut
Merge branch 'dev' into mnt/plan-toggle-ui-tests-1898
d39c1e3
@asnaith
add new element identifiers for downgrade details modal
7a9e5e3
@asnaith
add test to downgrade subscription plan
0343c33
@asnaith
Merge branch 'dev' into mnt/subscription-downgrade-ui-test-1918
24ec667
@Tbaut
Merge branch 'dev' into mnt/subscription-downgrade-ui-test-1918
7f3cc66
@asnaith
address pr feedback
6e533c3
@asnaith
Merge branch 'dev' into mnt/return-to-payment-crypto-tests-1921
8bceb72
@asnaith
add test for returning to pay crypto invoice
e595c1b
@asnaith
fix misc mistakes
ac8d9a7
@asnaith
Merge branch 'dev' into mnt/return-to-crypto-payment-tests-1921
4c76943
@asnaith
re-add accidentally removed test steps
5e1bf1e
@asnaith asnaith added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Feb 10, 2022
@render
Copy link

render bot commented Feb 10, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-1933.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c82apdc41ls8pls6u580.

@render
Copy link

render bot commented Feb 10, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-1933.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c82ape441ls8pls6u5f0.

@render
Copy link

render bot commented Feb 10, 2022

Your Render PR Server URL is https://files-ui-stage-pr-1933.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c82apek41ls8pls6u5sg.

FSM1
FSM1 approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@FSM1 FSM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff @asnaith

Tbaut
Tbaut reviewed Feb 11, 2022
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great, just found 2 nits, one of them not being due to this PR, bit it's so small that I allowed myself to make a suggestion :)

packages/files-ui/src/Components/Modules/Settings/SubscriptionTab/Common/CryptoPayment.tsx Outdated Show resolved Hide resolved
packages/files-ui/src/Components/Modules/Settings/SubscriptionTab/Common/CryptoPayment.tsx Outdated Show resolved Hide resolved
@Tbaut Tbaut enabled auto-merge (squash) February 11, 2022 14:53
@Tbaut Tbaut merged commit bac2ead into dev Feb 11, 2022
@Tbaut Tbaut deleted the mnt/return-to-crypto-payment-tests-1921 branch February 11, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaut Tbaut Tbaut approved these changes

@FSM1 FSM1 FSM1 approved these changes

@tanmoyAtb tanmoyAtb Awaiting requested review from tanmoyAtb

Assignees
No one assigned
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ui test for return to crypto payment
4 participants
@asnaith @FSM1 @Tbaut @actions-user